Refactor DefaultLoggingRuleConfigurationBuilder
to reduce usage of logback-classic
#32418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32377.
Changes proposed in this pull request:
DefaultLoggingRuleConfigurationBuilder
to reduce usage oflogback-classic
. Apparently the adapter fororg.slf4j.impl.StaticLoggerBinder
is not inlogback-core
. It looks like there is no other way. Keep logback-classic in the classpath of shardingsphere jdbc.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.