add p6spy driver support to ShardingJDBC infra#31814
Merged
linghengqian merged 2 commits intoapache:masterfrom Jun 22, 2024
Merged
add p6spy driver support to ShardingJDBC infra#31814linghengqian merged 2 commits intoapache:masterfrom
linghengqian merged 2 commits intoapache:masterfrom
Conversation
Member
linghengqian
left a comment
linghengqian
left a comment
There was a problem hiding this comment.
- The PR did not pass the code formatting validation. You can execute first
./mvnw spotless:apply -Pcheck -T1C. Then execute./mvnw checkstyle:check -Pcheck -T1Cto manually adjust to repair the CI.
...rc/main/java/org/apache/shardingsphere/infra/database/p6spy/type/P6spyMySQLDatabaseType.java
Show resolved
Hide resolved
...a/org/apache/shardingsphere/infra/database/testcontainers/type/TcP6spyMySQLDatabaseType.java
Outdated
Show resolved
Hide resolved
jiangML
pushed a commit
to jiangML/shardingsphere
that referenced
this pull request
Jun 24, 2024
* add p6spy driver support to ShardingJDBC infra * remove unnecessary dependency and testcontainers modify
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31782 .
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.