Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete insert statement #12186

Merged
merged 7 commits into from
Sep 3, 2021
Merged

Complete insert statement #12186

merged 7 commits into from
Sep 3, 2021

Conversation

soulasuna
Copy link
Contributor

Complete insert statement

For #11661

Changes proposed in this pull request:

  • Add shadow statement validator.
  • Optimize the xml configuration tag name.
  • Add future shadow example.

@tristaZero tristaZero added this to the 5.0.0-RC1 milestone Sep 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #12186 (4261f8f) into master (1301a41) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #12186      +/-   ##
============================================
- Coverage     63.73%   63.69%   -0.05%     
- Complexity     1258     1259       +1     
============================================
  Files          2327     2330       +3     
  Lines         35413    35445      +32     
  Branches       6161     6169       +8     
============================================
+ Hits          22570    22576       +6     
- Misses        11029    11050      +21     
- Partials       1814     1819       +5     
Impacted Files Coverage Δ
...e/shardingsphere/shadow/route/ShadowSQLRouter.java 81.63% <0.00%> (-7.26%) ⬇️
...ine/validator/ShadowStatementValidatorFactory.java 0.00% <0.00%> (ø)
.../validator/dml/ShadowInsertStatementValidator.java 0.00% <0.00%> (ø)
...engine/dml/ShadowInsertStatementRoutingEngine.java 71.42% <50.00%> (-17.47%) ⬇️
...ner/algorithm/ColumnShadowAlgorithmDeterminer.java 90.00% <87.50%> (+3.04%) ⬆️
...d/text/distsql/ral/common/hint/HintSourceType.java 0.00% <0.00%> (-42.86%) ⬇️
...ster/governance/registry/cache/node/CacheNode.java 75.00% <0.00%> (-25.00%) ⬇️
...ter/governance/registry/state/node/StatesNode.java 72.22% <0.00%> (-6.95%) ⬇️
...re/agent/core/plugin/PluginBootServiceManager.java 0.00% <0.00%> (ø)
...sphere/proxy/initializer/BootstrapInitializer.java 0.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1301a41...4261f8f. Read the comment docs.

@tristaZero tristaZero merged commit 83b5c8f into apache:master Sep 3, 2021
@soulasuna soulasuna deleted the complete-insert-statement branch September 3, 2021 11:57
@menghaoranss menghaoranss modified the milestones: 5.0.0-RC1, 5.0.0 Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants