Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New enhancement for registry. #1167

Merged
merged 243 commits into from
Aug 20, 2018
Merged

New enhancement for registry. #1167

merged 243 commits into from
Aug 20, 2018

Conversation

tristaZero
Copy link
Contributor

Fixes #1150 #1151 #1153 .

Changes proposed in this pull request:

  • Close old dataSources for registry when refresh.
  • Modify the usage for CircuitBreakerDataSource in registry.
  • Decouple Sharding-Orchestration from Sharding-JDBC.
  • Modify some unit tests.
  • Significantly alter ShardingDataSource and ShardingContext.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (dev@b4735e1). Click here to learn what that means.
The diff coverage is 26.69%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev    #1167   +/-   ##
======================================
  Coverage       ?   57.42%           
======================================
  Files          ?      664           
  Lines          ?    12830           
  Branches       ?     2046           
======================================
  Hits           ?     7368           
  Misses         ?     4998           
  Partials       ?      464
Impacted Files Coverage Δ
.../core/jdbc/core/connection/ShardingConnection.java 52.17% <ø> (ø)
.../core/orche/resultset/CircuitBreakerResultSet.java 0% <ø> (ø)
.../core/orche/statement/CircuitBreakerStatement.java 0% <ø> (ø)
...orche/metadata/CircuitBreakerDatabaseMetaData.java 96.69% <ø> (ø)
...ore/orche/datasource/CircuitBreakerDataSource.java 100% <ø> (ø)
...ore/orche/connection/CircuitBreakerConnection.java 100% <ø> (ø)
...che/resultset/CircuitBreakerResultSetMetaData.java 0% <ø> (ø)
...tion/internal/config/ConfigMapListenerManager.java 61.9% <ø> (ø)
...us/state/circuit/CircuitStateEventBusInstance.java 0% <ø> (ø)
...che/statement/CircuitBreakerPreparedStatement.java 0% <ø> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4735e1...5521f60. Read the comment docs.

@terrymanu terrymanu merged commit f38eb2d into apache:dev Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants