Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor api for shardingsphere-shadow. #11667

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Refactor api for shardingsphere-shadow. #11667

merged 1 commit into from
Aug 6, 2021

Conversation

soulasuna
Copy link
Contributor

Refactor api for shardingsphere-shadow.

For #11661

  • Add configuration class.
  • Add shadow algorithm interface

@codecov-commenter
Copy link

Codecov Report

Merging #11667 (0eb9366) into master (29148e3) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11667      +/-   ##
============================================
+ Coverage     63.79%   63.85%   +0.05%     
  Complexity     1121     1121              
============================================
  Files          2254     2254              
  Lines         34444    34447       +3     
  Branches       6018     6018              
============================================
+ Hits          21974    21996      +22     
+ Misses        10698    10678      -20     
- Partials       1772     1773       +1     
Impacted Files Coverage Δ
...ere/shadow/api/config/ShadowRuleConfiguration.java 0.00% <0.00%> (ø)
...ing/core/job/task/incremental/IncrementalTask.java 75.00% <0.00%> (+2.08%) ⬆️
...scaling/core/job/task/inventory/InventoryTask.java 75.55% <0.00%> (+6.66%) ⬆️
...re/scaling/core/executor/engine/ExecuteEngine.java 100.00% <0.00%> (+11.11%) ⬆️
...sphere/scaling/core/job/schedule/JobScheduler.java 51.85% <0.00%> (+29.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29148e3...0eb9366. Read the comment docs.

@tristaZero tristaZero merged commit a2fc27a into apache:master Aug 6, 2021
@tristaZero tristaZero added this to the 5.0.0-RC1 milestone Aug 6, 2021
@soulasuna soulasuna deleted the shadow-api-reconstruction branch August 6, 2021 01:41
@menghaoranss menghaoranss modified the milestones: 5.0.0-RC1, 5.0.0 Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants