Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#373, support "order by ?" #1146

Merged
merged 5 commits into from
Aug 15, 2018
Merged

#373, support "order by ?" #1146

merged 5 commits into from
Aug 15, 2018

Conversation

tuohai666
Copy link
Member

Fixes #373 .

Changes proposed in this pull request:

@codecov-io
Copy link

codecov-io commented Aug 15, 2018

Codecov Report

Merging #1146 into dev will increase coverage by 0.05%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1146      +/-   ##
==========================================
+ Coverage   57.99%   58.05%   +0.05%     
==========================================
  Files         666      664       -2     
  Lines       12892    12868      -24     
  Branches     2068     2062       -6     
==========================================
- Hits         7477     7470       -7     
+ Misses       4942     4924      -18     
- Partials      473      474       +1
Impacted Files Coverage Δ
...gsphere/core/parsing/parser/context/OrderItem.java 78.72% <0%> (-13.78%) ⬇️
...ore/parsing/parser/clause/OrderByClauseParser.java 82.05% <64.28%> (-11.7%) ⬇️
...sphere/core/executor/event/EventExecutionType.java 0% <0%> (-100%) ⬇️
...o/shardingsphere/core/executor/ExecutorEngine.java 91.22% <0%> (-0.3%) ⬇️
...shardingsphere/opentracing/ShardingJDBCTracer.java 100% <0%> (ø) ⬆️
...acket/command/query/text/query/ComQueryPacket.java 0% <0%> (ø) ⬆️
...core/executor/event/AbstractSQLExecutionEvent.java
...gsphere/core/merger/event/ResultSetMergeEvent.java
...shardingsphere/opentracing/MergeEventListener.java
...dingsphere/core/routing/event/SqlRoutingEvent.java
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2db529...45bb004. Read the comment docs.

@terrymanu terrymanu merged commit a295f5e into apache:dev Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants