Code optimization for shardingsphere-shadow project. (#11282) #11285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulasuna
changed the title
Codecov Report
@@ Coverage Diff @@
## master #11285 +/- ##
============================================
- Coverage 63.49% 63.46% -0.04%
Complexity 1026 1026
============================================
Files 2200 2206 +6
Lines 33608 33683 +75
Branches 5881 5895 +14
============================================
+ Hits 21340 21376 +36
- Misses 10567 10601 +34
- Partials 1701 1706 +5
Continue to review full report at Codecov.
|
tristaZero
requested changes
Jul 13, 2021
| @@ -41,4 +41,8 @@ public final boolean isNeedRewrite(final SQLStatementContext sqlStatementContext | |||
| } | |||
|
|
|||
| protected abstract boolean isNeedRewriteForShadow(SQLStatementContext sqlStatementContext); | |||
|
|
|||
| protected String getShadowColumn() { | |||
| return shadowRule.getColumn(); | |||
There was a problem hiding this comment.
Why do we need another function?
There was a problem hiding this comment.
Each subclass is called multiple times, and protected methods are extracted from the parent class.
tristaZero
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code optimization for shardingsphere-shadow project.
For #11282
Changes proposed in this pull request: