Skip to content

Commit

Permalink
Update CODE_OF_CONDUCT.md and code.en.md about hamcrest
Browse files Browse the repository at this point in the history
  • Loading branch information
linghengqian committed Sep 19, 2022
1 parent 023ba31 commit 4a30190
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ The following code of conduct is based on full compliance with [ASF CODE OF COND
- Without particular reasons, test cases should be fully covered.
- Every test case need precised assertion.
- Environment preparation codes should be separate from test codes.
- Only those that relate to junit `Assert`, hamcrest `CoreMatchers` and `Mockito` can use static import.
- Only those that relate to `Mockito`, junit `Assert`, hamcrest `CoreMatchers` and `MatcherAssert` can use static import.
- For single parameter asserts, `assertTrue`, `assertFalse`, `assertNull` and `assertNotNull` should be used.
- For multiple parameter asserts, `assertThat` should be used.
- For accurate asserts, try not to use `not`, `containsString` to make assertions.
Expand Down
2 changes: 1 addition & 1 deletion docs/community/content/involved/conduct/code.en.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ The following code of conduct is based on full compliance with [ASF CODE OF COND
- Test cases should be fully covered expect simply `getter /setter` methods, and declared static codes of SPI, such as: `getType / getOrder`.
- Every test case need precised assertion.
- Environment preparation codes should be separate from test codes.
- Only those that relate to junit `Assert`, hamcrest `CoreMatchers` and `Mockito` can use static import.
- Only those that relate to `Mockito`, junit `Assert`, hamcrest `CoreMatchers` and `MatcherAssert` can use static import.
- For single parameter asserts, `assertTrue`, `assertFalse`, `assertNull` and `assertNotNull` should be used.
- For multiple parameter asserts, `assertThat` should be used.
- For accurate asserts, try not to use `not`, `containsString` to make assertions.
Expand Down

0 comments on commit 4a30190

Please sign in to comment.