[SEDONA-324] R fix tests #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove compute
testing r branches
Clean up compute
Allow demo directory for development
R worklfow back to normal
|
There are still some warnings, I believe introduced by sparklyr 1.8.2. looking into that as well |
|
It worked on my fork, and package versions are the same, not clear what's going on. (https://github.com/gregleleu/sedona/actions/runs/5547961034) |
|
@gregleleu I cleaned up the cache and re-ran the R tests. It still fails... |
|
@gregleleu Your changes also fail on my fork: jiayuasu#1 |
Removed `compute` calls until new version of sparkylr is on CRAN
|
It's actually an issue with sparklyr not being ready fro dbplyr 2.3.3, but it's fixed in the development version. |
|
@gregleleu Thank you very much for your help! |
Kontinuation
pushed a commit
to Kontinuation/sedona
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
https://issues.apache.org/jira/browse/SEDONA-324
What changes were proposed in this PR?
Fixing the tests by removing the unneeded workaround
How was this patch tested?
By running the tests
Did this PR include necessary documentation updates?