Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] azure synapse analytics #1673

Merged
merged 10 commits into from
Nov 4, 2024

Conversation

golfalot
Copy link
Contributor

@golfalot golfalot commented Nov 3, 2024

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No:
    • this is a documentation update. The PR name follows the format [DOCS] my subject

What changes were proposed in this PR?

This tutorial will guide you through the process of installing Sedona on Azure Synapse Analytics when Data Exfiltration Protection (DEP) is enabled or when you have no internet connection from the Spark pools due to other networking constraints.

How was this patch tested?

Up and running in our production environment.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tutorial. Left some comments!

docs/setup/azure-synapse-analytics.md Outdated Show resolved Hide resolved
docs/setup/azure-synapse-analytics.md Show resolved Hide resolved
docs/setup/azure-synapse-analytics.md Show resolved Hide resolved
docs/setup/azure-synapse-analytics.md Outdated Show resolved Hide resolved
docs/setup/azure-synapse-analytics.md Outdated Show resolved Hide resolved
docs/setup/azure-synapse-analytics.md Show resolved Hide resolved
@jiayuasu
Copy link
Member

jiayuasu commented Nov 4, 2024

@golfalot Can you fix the lint issue?

fix tone
fix context build
add a preface note about why we're using specific version and not latest
remove author info
explain more about numpy issue
                'org.apache.sedona:sedona-spark-shaded-3.4_2.12-1.6.1,'
                'org.datasyslab:geotools-wrapper-1.6.1-28.2') \
@golfalot
Copy link
Contributor Author

golfalot commented Nov 4, 2024

@jiayuasu I'm all done with commits now if you'd be kind enough to retrigger the workflow so I can check the linting is ok.

@golfalot
Copy link
Contributor Author

golfalot commented Nov 4, 2024

Hi @jiayuasu I'm such n00b at this.... Further corrections now committed. Hoping this is the last!

@jiayuasu
Copy link
Member

jiayuasu commented Nov 4, 2024

@golfalot Can you run pre-commit run --all-files locally? You can install it here: https://pre-commit.com/

@jiayuasu jiayuasu merged commit 25b2c2b into apache:master Nov 4, 2024
3 checks passed
jiayuasu pushed a commit that referenced this pull request Nov 4, 2024
* docs: add tutorial for installing Sedona on Azure Synapse Analytics with DEP enabled

* link to main docs index, rename file

* fix linting
fix tone
fix context build
add a preface note about why we're using specific version and not latest
remove author info
explain more about numpy issue

* add org.apache.sedona.sql.SedonaSqlExtensions

* is in fact required:         .config('spark.jars.packages',
                'org.apache.sedona:sedona-spark-shaded-3.4_2.12-1.6.1,'
                'org.datasyslab:geotools-wrapper-1.6.1-28.2') \

* fix 4 blank lines, 2 trailing spaces

* fix typos. fix tone

* fix end of files

* undo bad markdown and pass pre-commit

* grammar

---------

Co-authored-by: Tim Downs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants