[CI] Remove macos from Docker build #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Root cause is the recent QEMU 9.10 breaks with Colima. See another issue here: douglascamata/setup-docker-macos-action#37 |
jbampton
reviewed
Oct 23, 2024
.github/workflows/docker-build.yml
Outdated
| brew install qemu.rb 2>&1 | ||
| continue-on-error: true | ||
| - name: Setup tmate session | ||
| uses: mxschmitt/action-tmate@v3 |
There was a problem hiding this comment.
jiayuasu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[CI] my subjectWhat changes were proposed in this PR?
macos-12is being deprecated by GitHub and starts to break sometimes: [macOS] ThemacOS 12Actions runner image will begin deprecation on 10/7/24 and will be fully unsupported by 12/3/24 for GitHub and ADO actions/runner-images#10721macos-13image douglascamata/setup-docker-macos-action#37, andmacos-13not working douglascamata/setup-docker-macos-action#41).After numerous attempts, the MacOS build sometimes can finish now but still occasionally crash. Therefore, this PR will remove macos build and we plan to add it back in the future.
How was this patch tested?
Passed CI
Did this PR include necessary documentation updates?