Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling in a Python file #1642

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix spelling in a Python file #1642

wants to merge 1 commit into from

Conversation

jbampton
Copy link
Member

@jbampton jbampton commented Oct 15, 2024 •
edited
Loading

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No.

What changes were proposed in this PR?

Fixed a typo

How was this patch tested?

https://www.merriam-webster.com/thesaurus/inferable

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@jbampton jbampton changed the title Fix spelling tests(python): fix spelling Oct 15, 2024
@jbampton jbampton changed the title tests(python): fix spelling Fix spelling in Python and Scala files Oct 15, 2024
@jbampton jbampton marked this pull request as draft October 15, 2024 14:50
@jbampton jbampton marked this pull request as ready for review October 15, 2024 15:37
jiayuasu
jiayuasu requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing Inferrable with Inferable does not seem to be necessary and it affects too many files in the project. Please only keep the change of conversion

@jbampton jbampton marked this pull request as draft October 25, 2024 04:20
@jbampton jbampton self-assigned this Oct 29, 2024
@jbampton jbampton marked this pull request as ready for review November 5, 2024 11:22
@jbampton jbampton changed the title Fix spelling in Python and Scala files Fix spelling in a Python file Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiayuasu jiayuasu Awaiting requested review from jiayuasu jiayuasu is a code owner

Assignees

@jbampton jbampton

Labels
sedona-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbampton @jiayuasu