Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-447] pre-commit: apply end-of-file-fixer to more files #1147

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

jbampton
Copy link
Member

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

https://github.com/pre-commit/pre-commit-hooks#end-of-file-fixer

Fixing the end of files for many more files / file types.

Standardizes the code base.

When run locally it will automatically fix the end of files.

On GitHub actions it is just pass or fail.

How was this patch tested?

pre-commit run --all-files

or

pre-commit run end-of-file-fixer --all-files

If needed we can exclude more files from this check

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu jiayuasu merged commit 13e6a7b into apache:master Dec 16, 2023
42 checks passed
@jbampton jbampton deleted the end-of-file-fixer-more-files branch December 16, 2023 10:50
Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants