Skip to content

Conversation

@dybyte
Copy link
Contributor

@dybyte dybyte commented Oct 28, 2025

Fixes: #9851

Purpose of this pull request

This PR implements the basic RocksDB storage layer.
After gathering feedback, I plan to further improve the storage code and migrate other Imap instances to RocksDB, updating the documentation along the way.

Does this PR introduce any user-facing change?

Yes.
Users should now configure map-store settings in seatunnel.yaml instead of hazelcast.yaml.

How was this patch tested?

Added RocksDBServiceTest.

Check list

@dybyte dybyte marked this pull request as draft October 28, 2025 08:37
@github-actions github-actions bot added the Zeta label Oct 28, 2025
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 28, 2025
@dybyte dybyte marked this pull request as ready for review October 29, 2025 07:10
@dybyte
Copy link
Contributor Author

dybyte commented Oct 31, 2025

Hi @Hisoka-X @zhangshenghang @liugddx, please take a look when you have time. Thanks!

@zhangshenghang
Copy link
Member

The configuration file is migrated from hazelcast.yaml to seatunnel.yaml, which is a breaking change.Can we provide a configuration migration tool or script?

@zhangshenghang
Copy link
Member

It is recommended to be compatible with both methods at the same time and consider being compatible with the old configuration for a period of time.
In addition, since this is a major change, could you supplement your design plan?

@dybyte
Copy link
Contributor Author

dybyte commented Nov 2, 2025

The configuration file is migrated from hazelcast.yaml to seatunnel.yaml, which is a breaking change.Can we provide a configuration migration tool or script?

It is recommended to be compatible with both methods at the same time and consider being compatible with the old configuration for a period of time.
In addition, since this is a major change, could you supplement your design plan?

The design document can be found in the Apache dev mailing list.
You can quickly get the context by checking the related comments there. @zhangshenghang

For compatibility, I’ll make the configuration still available in hazelcast.yaml for now.
A migration tool will be provided later.

@dybyte
Copy link
Contributor Author

dybyte commented Nov 3, 2025

Hi @hawk9821 , PTAL when you have a moment. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Zeta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Zeta] Replace Imap by rocksdb

2 participants