Skip to content

Conversation

@dybyte
Copy link
Contributor

@dybyte dybyte commented Oct 24, 2025

Purpose of this pull request

This PR fixes DruidIT CI errors.

2025-10-24T02:31:12.2037113Z [ERROR] Errors: 
2025-10-24T02:31:12.2038064Z [ERROR]   DruidIT.testDruidMultiSink:138 » ConditionTimeout Assertion condition defined ...
2025-10-24T02:31:12.2039247Z [ERROR]   DruidIT.testDruidMultiSink:138 » ConditionTimeout Assertion condition defined ...
2025-10-24T02:31:12.2040251Z [ERROR]   DruidIT.testDruidSink:105 » ConditionTimeout Assertion condition defined as a ...
2025-10-24T02:31:12.2041252Z [ERROR]   DruidIT.testDruidSink:105 » ConditionTimeout Assertion condition defined as a ...
2025-10-24T02:31:12.2041874Z [ERROR]   DruidIT.testDruidSink:105 » ConditionTimeout Assertion condition defined as a ...
2025-10-24T02:31:12.2042457Z [ERROR]   DruidIT.testDruidSink:105 » ConditionTimeout Assertion condition defined as a ...
2025-10-24T02:31:12.2043196Z [ERROR]   DruidIT.testDruidSink:105 » ConditionTimeout Assertion condition defined as a ...

I identified two root causes.

  1. Druid router connection: The tests were trying to connect to 127.0.0.1:8888, which does not work inside the Docker network. The correct approach is to use the Docker Compose service name router:8888.
Caused by: org.apache.http.conn.HttpHostConnectException: Connect to 127.0.0.1:8888 [/127.0.0.1] failed: Connection refused (Connection refused)
  1. PostgreSQL version: The postgres:latest image now uses a new data directory structure for version 18+, which can cause startup issues if old mounts are used. See postgres Docker update and discussion.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Covered by existing tests.

Check list

@github-actions github-actions bot added the e2e label Oct 24, 2025
Copy link
Contributor

@chl-wxp chl-wxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes DruidIT end-to-end test failures caused by connection issues and PostgreSQL version incompatibility. The tests were timing out because they couldn't properly connect to Druid services and the PostgreSQL metadata store had startup problems.

Key Changes:

  • Updated Druid coordinator URL from localhost to Docker service name for proper container networking
  • Modified PostgreSQL volume mount path to be compatible with PostgreSQL 18+ data directory structure

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
fakesource_to_druid.conf Changed coordinator URL to use Docker service name instead of localhost
fakesource_to_druid_with_multi.conf Changed coordinator URL to use Docker service name instead of localhost
docker-compose.yml Updated PostgreSQL volume mount path for version 18+ compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@zhangshenghang zhangshenghang merged commit 4ceea92 into apache:dev Oct 26, 2025
6 checks passed
@dybyte dybyte deleted the fix/druid-it branch October 26, 2025 13:19
davidzollo pushed a commit to davidzollo/seatunnel that referenced this pull request Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants