[Feature][Connector-V2] sftp file sink suport multiple table and save mode #7668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Sep 18, 2024
| @TestTemplate | ||
| @DisabledOnContainer( | ||
| value = {}, | ||
| type = {EngineType.FLINK, EngineType.SPARK}, |
There was a problem hiding this comment.
Suggested change
| type = {EngineType.FLINK, EngineType.SPARK}, | |
| type = {EngineType.FLINK}, |
| @@ -0,0 +1,103 @@ | |||
| # | |||
There was a problem hiding this comment.
Please rename the test case file name. I can not get the difference of two config from config name.
Hisoka-X
reviewed
Sep 29, 2024
Comment on lines
153
to
156
| @DisabledOnContainer( | ||
| value = {}, | ||
| type = {EngineType.FLINK}, | ||
| disabledReason = "Flink dosen't support multi-table at now") |
Hisoka-X
approved these changes
Sep 29, 2024
hailin0
approved these changes
Sep 29, 2024
dailai
pushed a commit
to dailai/seatunnel
that referenced
this pull request
Oct 11, 2024
fcb-xiaobo
pushed a commit
to fcb-xiaobo/seatunnel
that referenced
this pull request
Oct 11, 2024
CosmosNi
pushed a commit
to CosmosNi/seatunnel
that referenced
this pull request
Oct 15, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.