-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2] Optimize hudi sink #7662
Conversation
…efore fetch task start (apache#5008)
| min_commits_to_keep | Int | no | 20 | | ||
| max_commits_to_keep | Int | no | 30 | | ||
| common-options | config | no | - | | ||
Base configuration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update zh docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update zh docs
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. cc @liugddx
"sh", "-c", "cd /tmp" + " && tar -zxvf " + NAMESPACE_TAR); | ||
try { | ||
Process process = processBuilder.start(); | ||
// 等待命令执行完成 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove Chinese
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove Chinese
done.
op_type="UPSERT" | ||
table_dfs_path = "/tmp/hudi" | ||
database = "st" | ||
table_name = "st_test" | ||
table_type="COPY_ON_WRITE" | ||
record_key_fields="c_bigint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without new config key op_type
, database
, table_type
, record_key_fields
, can the config execute normally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without new config key
op_type
,database
,table_type
,record_key_fields
, can the config execute normally?
Sorry, I did not consider that these item is empty, I have modified it.
Thanks @happyboy1024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
You can temporarily set |
Purpose of this pull request
This pr mainly focuses on some optimization of hudi sink. #7597
Moreover, fixed dependency problem with S3 as storage, and fixed multiple tables in spark and flink engines that did not execute savemode properly
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.