Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support config variable substitution with default value #7562

Merged
merged 16 commits into from
Sep 10, 2024

Conversation

zhangshenghang
Copy link
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

unit test and e2e test and Local

Check list

@github-actions github-actions bot added document core SeaTunnel core module e2e api labels Sep 3, 2024
@Hisoka-X Hisoka-X added this to the 2.3.8 milestone Sep 3, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhangshenghang ! I left some comment.

docs/en/concept/config.md Outdated Show resolved Hide resolved
docs/en/concept/config.md Outdated Show resolved Hide resolved
docs/en/concept/config.md Outdated Show resolved Hide resolved
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @zhangshenghang !

@hailin0 hailin0 merged commit bc1a6b4 into apache:dev Sep 10, 2024
7 checks passed
@zhangshenghang zhangshenghang deleted the feature-default-value-variable branch September 10, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Core] Support config variable substitution with default value
3 participants