Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Transform] Support errorHandleWay on jsonpath transform #7524

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Aug 29, 2024

Purpose of this pull request

[Improve][Transform] Ignore error with jsonpath transform

Does this PR introduce any user-facing change?

Add new config item

How was this patch tested?

Added

Check list

@FuYouJ
Copy link
Contributor

FuYouJ commented Aug 31, 2024

good idea

@hailin0 hailin0 force-pushed the dev-fix-transform branch 3 times, most recently from 13682b1 to fabd8c1 Compare September 5, 2024 10:58
@hailin0 hailin0 marked this pull request as ready for review September 5, 2024 12:56
@hailin0 hailin0 changed the title [Improve][Transform] Ignore error with jsonpath transform [Improve][Transform] Support errorHandleWay on jsonpath transform Sep 5, 2024
@github-actions github-actions bot added the e2e label Sep 5, 2024
@hailin0
Copy link
Member Author

hailin0 commented Sep 6, 2024

image

@github-actions github-actions bot added the core SeaTunnel core module label Sep 6, 2024
@@ -102,11 +104,23 @@ public List<DatasetTableInfo> execute(List<DatasetTableInfo> upstreamDataStreams
}
ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
DatasetTableInfo input = upstreamDataStreams.get(0);

Map<String, DatasetTableInfo> outputTables =
upstreamDataStreams.stream()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix spark bugs when jsonpath e2e

@@ -85,12 +88,22 @@ public List<DataStreamTableInfo> execute(List<DataStreamTableInfo> upstreamDataS
return upstreamDataStreams;
}
DataStreamTableInfo input = upstreamDataStreams.get(0);
Map<String, DataStreamTableInfo> outputTables =
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix spark bugs when jsonpath e2e

Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Carl-Zhou-CN Carl-Zhou-CN merged commit 7532a94 into apache:dev Sep 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants