-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Zeta] Support slf4j mdc tracing job id output into logs #7491
Conversation
b2e749e
to
b8fcb17
Compare
c9c175d
to
9c546ec
Compare
0c06e63
to
a2860eb
Compare
a2860eb
to
188047b
Compare
5c93167
to
ed5e863
Compare
ed5e863
to
33490a6
Compare
<exclusions> | ||
<exclusion> | ||
<groupId>org.slf4j</groupId> | ||
<artifactId>slf4j-log4j12</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -83,6 +83,7 @@ done | |||
|
|||
# Log4j2 Config | |||
JAVA_OPTS="${JAVA_OPTS} -Dlog4j2.contextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector" | |||
JAVA_OPTS="${JAVA_OPTS} -Dlog4j2.isThreadContextMapInheritable=true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Good feature, Thanks @hailin0 for working on this. |
@arshadmohammad |
I was looking for functionality similar to mapreduce and yarn, all mapreduce jobs have separate logs. |
I will do some verification later |
Purpose of this pull request
[Feature][Zeta] Support slf4j mdc tracing job id output into logs
reference
https://www.slf4j.org/manual.html#mdc
https://logging.apache.org/log4j/2.x/manual/thread-context.html#configuration
https://logging.apache.org/log4j/2.x/manual/layouts.html#PatternLayout
subtask of #2725
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added
Check list
New License Guide
release-note
.