Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixbug] doris custom sql work #7464

Merged
merged 9 commits into from
Aug 24, 2024

Conversation

zhangshenghang
Copy link
Member

Purpose of this pull request

fix #7367

doris did not implement this function before, but now it has been completed

How was this patch tested?

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case. Thanks

@zhangshenghang
Copy link
Member Author

Please add test case. Thanks

Ok ,I will add it

@github-actions github-actions bot added the e2e label Aug 23, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @zhangshenghang !

@hailin0 hailin0 merged commit 5c6a7c6 into apache:dev Aug 24, 2024
5 checks passed
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
@zhangshenghang zhangshenghang deleted the fixbug-doris-custom-sql-work branch August 31, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Module Name] Doris custom_sql can't work
3 participants