Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Zeta] Fix task can not end cause by lock metrics failed #7357

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Aug 9, 2024

Purpose of this pull request

If the engine is overloaded, the distributed lock for obtaining metrics may fail or block, which currently prevents the task from completing normally. This PR will try to give up updating metrics to ensure the normal operation of the task.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test

Check list

@github-actions github-actions bot added the Zeta label Aug 9, 2024
@github-actions github-actions bot added the e2e label Aug 9, 2024
@@ -65,8 +64,6 @@ public void before() {
}

@Test
@Disabled(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reopen test case which we should open!

@Hisoka-X Hisoka-X requested a review from hailin0 August 9, 2024 12:51
@Hisoka-X Hisoka-X merged commit 6a7df83 into apache:dev Aug 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants