-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E2E][HBase]Refactor hbase e2e #6859
Conversation
good |
...-e2e/connector-hbase-e2e/src/test/java/org/apache/seatunnel/e2e/connector/hbase/HbaseIT.java
Outdated
Show resolved
Hide resolved
...on/src/test/java/org/apache/seatunnel/e2e/common/container/seatunnel/SeaTunnelContainer.java
Outdated
Show resolved
Hide resolved
Hello, @Hisoka-X . When I open the zeta engine to test hbase, a new error will appear: Failed to load SIMPLE, KERBEROS, and DIGEST authentication providers. Classpath is not sane. I looked up the information about this error: This exception only occurs occasionally, and not every time will be reported. You know, occasional errors can also cause ci failure. I thought it was an hbase bug (the error was about classpath, not code), so I disabled the zeta test. If needed later, I plan to build habse's docker container myself to try and fix it. In this pr, I temporarily disabled zeta testing. |
@Hisoka-X @hailin0 @EricJoy2048 Do I need to make any changes to this pr? |
<dependency> | ||
<groupId>org.apache.seatunnel</groupId> | ||
<artifactId>connector-fake</artifactId> | ||
<version>${project.version}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<version>${project.version}</version> | |
<version>${project.version}</version> | |
<scope>test</scope> |
Do you need to maintain the same style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your advice. I have already modified it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for review. @hailin0 @Hisoka-X @Carl-Zhou-CN |
Purpose of this pull request
At present, the hbase e2e test is disabled by default. This pr refactor the hbase e2e test module to enable ci check and passes flink, spark, and zeta engine tests.
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.