Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E][HBase]Refactor hbase e2e #6859

Merged
merged 19 commits into from
Jun 4, 2024
Merged

[E2E][HBase]Refactor hbase e2e #6859

merged 19 commits into from
Jun 4, 2024

Conversation

TaoZex
Copy link
Contributor

@TaoZex TaoZex commented May 15, 2024

Purpose of this pull request

At present, the hbase e2e test is disabled by default. This pr refactor the hbase e2e test module to enable ci check and passes flink, spark, and zeta engine tests.

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@TaoZex
Copy link
Contributor Author

TaoZex commented May 15, 2024

1.Remove disabled
image
2.Success test in flink, spark, and zeta engines
image

@TaoZex TaoZex closed this May 16, 2024
@TaoZex TaoZex reopened this May 16, 2024
@TaoZex TaoZex closed this May 16, 2024
@TaoZex TaoZex reopened this May 16, 2024
@TaoZex TaoZex marked this pull request as draft May 16, 2024 05:36
@TaoZex TaoZex marked this pull request as ready for review May 18, 2024 07:23
@TaoZex TaoZex marked this pull request as draft May 18, 2024 10:16
@TaoZex TaoZex marked this pull request as ready for review May 18, 2024 18:04
@TaoZex
Copy link
Contributor Author

TaoZex commented May 20, 2024

@hailin0
Copy link
Member

hailin0 commented May 22, 2024

good

@TaoZex
Copy link
Contributor Author

TaoZex commented May 25, 2024

Hello, @Hisoka-X . When I open the zeta engine to test hbase, a new error will appear: Failed to load SIMPLE, KERBEROS, and DIGEST authentication providers. Classpath is not sane.

I looked up the information about this error:
1.https://issues.apache.org/jira/browse/HBASE-25338
2.#6047

This exception only occurs occasionally, and not every time will be reported. You know, occasional errors can also cause ci failure. I thought it was an hbase bug (the error was about classpath, not code), so I disabled the zeta test. If needed later, I plan to build habse's docker container myself to try and fix it. In this pr, I temporarily disabled zeta testing.

@TaoZex
Copy link
Contributor Author

TaoZex commented Jun 3, 2024

@Hisoka-X @hailin0 @EricJoy2048 Do I need to make any changes to this pr?

Hisoka-X
Hisoka-X previously approved these changes Jun 3, 2024
<dependency>
<groupId>org.apache.seatunnel</groupId>
<artifactId>connector-fake</artifactId>
<version>${project.version}</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>${project.version}</version>
<version>${project.version}</version>
<scope>test</scope>

Do you need to maintain the same style?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your advice. I have already modified it.

Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit 1da9bd6 into apache:dev Jun 4, 2024
5 checks passed
@TaoZex
Copy link
Contributor Author

TaoZex commented Jun 19, 2024

Thanks for review. @hailin0 @Hisoka-X @Carl-Zhou-CN

chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants