-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][JDBC Source] Fix Split can not be cancel #6825
[Improve][JDBC Source] Fix Split can not be cancel #6825
Conversation
959232d
to
ef45e25
Compare
ef45e25
to
bd55b74
Compare
@@ -337,6 +337,9 @@ default Object[] sampleDataFromColumn( | |||
if (count % samplingRate == 0) { | |||
results.add(rs.getObject(1)); | |||
} | |||
if (Thread.currentThread().isInterrupted()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change this?
Line 101 in 329b849
return sampleDataFromColumn(jdbc, tableId, column.name(), samplingRate); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of this pull request
Solve the problem of job being unable to be savepoint and cancelled during split chunk.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Check list
New License Guide
release-note
.