Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][JDBC Source] Fix Split can not be cancel #6825

Merged

Conversation

EricJoy2048
Copy link
Member

@EricJoy2048 EricJoy2048 commented May 9, 2024

Purpose of this pull request

Solve the problem of job being unable to be savepoint and cancelled during split chunk.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Check list

@EricJoy2048 EricJoy2048 changed the title [JDBC Source] Fix Split can not be cancel [Improve][JDBC Source] Fix Split can not be cancel May 10, 2024
@EricJoy2048 EricJoy2048 force-pushed the apache_240509_fix_splitchunk_can_not_cancel branch from 959232d to ef45e25 Compare May 10, 2024 05:38
@EricJoy2048 EricJoy2048 force-pushed the apache_240509_fix_splitchunk_can_not_cancel branch from ef45e25 to bd55b74 Compare May 10, 2024 07:25
@@ -337,6 +337,9 @@ default Object[] sampleDataFromColumn(
if (count % samplingRate == 0) {
results.add(rs.getObject(1));
}
if (Thread.currentThread().isInterrupted()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, added

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricJoy2048 EricJoy2048 merged commit ee3b7c3 into apache:dev May 14, 2024
5 checks passed
liunaijie pushed a commit to liunaijie/seatunnel that referenced this pull request Aug 1, 2024
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants