Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Connector] Add some sqlserver IDENTITY type for catalog #6822

Merged
merged 3 commits into from
May 9, 2024
Merged

[Improve][Connector] Add some sqlserver IDENTITY type for catalog #6822

merged 3 commits into from
May 9, 2024

Conversation

chl-wxp
Copy link
Contributor

@chl-wxp chl-wxp commented May 9, 2024 •
edited
Loading

Check list

  • The SQLSERVER database will have a type of 'Identity' suffix, which requires compatibility.

Hisoka-X
Hisoka-X approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. By the way, please use default PR template next time.

@Hisoka-X Hisoka-X changed the title [update][Connector]add some sqlserver IDENTITY type for catalog [Improve][Connector] Add some sqlserver IDENTITY type for catalog May 9, 2024
@hailin0 hailin0 merged commit f698396 into apache:dev May 9, 2024
4 checks passed
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
@chl-wxp
[Improve][Connector] Add some sqlserver IDENTITY type for catalog (ap…
fbe87b1 
…ache#6822)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@hailin0 hailin0 hailin0 approved these changes

Assignees
No one assigned
Labels
approved improve reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chl-wxp @hailin0 @Hisoka-X