[Improve] Optimize log display during startup command #6816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @JohnZp for created this PR! |
Hisoka-X
reviewed
May 10, 2024
| @@ -62,7 +62,7 @@ REM port in your IDE. After that, you can happily debug your code. | |||
| REM set "JAVA_OPTS=%JAVA_OPTS% -Xdebug -Xrunjdwp:server=y,transport=dt_socket,address=5001,suspend=y" | |||
|
|
|||
| if exist "%CONF_DIR%\log4j2.properties" ( | |||
| set "JAVA_OPTS=%JAVA_OPTS% -Dlog4j2.configurationFile=%CONF_DIR%\log4j2.properties" | |||
| set "JAVA_OPTS=%JAVA_OPTS% -Dhazelcast.logging.type=log4j2 -Dlog4j2.configurationFile=%CONF_DIR%\log4j2.properties" | |||
There was a problem hiding this comment.
Sorry I'm late, this is a good pr
wuchunfu
approved these changes
May 12, 2024
|
LGTM |
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
Co-authored-by: JohnZp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Some config loading log don't take effect about log4j2
When we startup a command like seatunnel.sh -l, the log as follows.
Generally, if you execute commands through some programs, such non-standard logs will be captured in the error log stream, which is very bad
Does this PR introduce any user-facing
How was this patch tested?
Check list
New License Guide
release-note.