Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix get seatunnel row size npe issue #6681

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

liunaijie
Copy link
Member

Purpose of this pull request

close #6455

Does this PR introduce any user-facing change?

How was this patch tested?

update the current ut

Check list

@Hisoka-X Hisoka-X added bug core SeaTunnel core module labels Apr 10, 2024
@Hisoka-X Hisoka-X added this to the 2.3.5 milestone Apr 10, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one minior problem.

Comment on lines 55 to 58
new Integer[] {1, 2, 3},
new Long[] {1L, 2L, 3L},
new Double[] {1D, 2D},
new Float[] {1F, 2F}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed Boolean[], Byte[], Short[],

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @liunaijie !

@hailin0 hailin0 merged commit 4f4fd7b into apache:dev Apr 11, 2024
4 checks passed
lostinwind added a commit to lostinwind/dataGovernance that referenced this pull request Apr 12, 2024
@liunaijie liunaijie deleted the fix-rowsize branch April 16, 2024 06:10
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [SinkMetrics] the sink metrics collect will get NPE when data type is String[]
3 participants