-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Paimon] Support specify paimon table write properties, partition keys and primary keys #6535
Conversation
619dadc
to
8f8a713
Compare
c4e8a92
to
a7626ba
Compare
if (primaryKeys.isEmpty() && Objects.nonNull(tableSchema.getPrimaryKey())) { | ||
primaryKeys = tableSchema.getPrimaryKey().getColumnNames(); | ||
} | ||
if (Objects.nonNull(primaryKeys) && primaryKeys.size() > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems impossible to be null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ition keys and primary keys (apache#6535)
Purpose of this pull request
[Feature][Paimon] Support specify paimon table write properties, partition keys and primary keys
[Feature][Paimon] Support timestamp(n) for the paimon sink
[Feature][API] ColumnParser support define columnScale which is useful for fakesource
For example:
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.