[Feature][Connectors-v2-Paimon] Support Date&Time Data Type To Be Flink Int#6076
Closed
SimonChou12138 wants to merge 3 commits into
Closed
[Feature][Connectors-v2-Paimon] Support Date&Time Data Type To Be Flink Int#6076SimonChou12138 wants to merge 3 commits into
SimonChou12138 wants to merge 3 commits into
Conversation
Contributor
Author
|
@TyrantLucifer PTAL,thanks. |
Member
|
@Carl-Zhou-CN PTAL. |
Carl-Zhou-CN
reviewed
Jan 9, 2024
| break; | ||
| case TIME: | ||
| LocalTime time = (LocalTime) seaTunnelRow.getField(i); | ||
| String timeStr = time.format(DateTimeFormatter.ofPattern("HH:mm:ss")); |
Member
There was a problem hiding this comment.
Do we need to support milliseconds?
Carl-Zhou-CN
reviewed
Jan 9, 2024
| LocalTime time = LocalTime.of(0, 0, 0); | ||
| binaryWriter.writeTimestamp( | ||
| i, Timestamp.fromLocalDateTime(date.atTime(time)), 3); | ||
| String dateStr = date.format(DateTimeFormatter.ofPattern("yyyy-MM-dd")); |
Member
There was a problem hiding this comment.
Wouldn't it be more convenient to directly obtain the number of days from LocalDate?
4 tasks
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
Contributor
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Implement Feature #6075
Does this PR introduce any user-facing change?
without
How was this patch tested?
e2e tests and unit test cases have been perfected
Check list
New License Guide
release-note.