Skip to content

[Improve][Flink] Remove useless stage type.#5650

Merged
hailin0 merged 1 commit into
apache:devfrom
CheneyYin:remove-flink-stage-type
Oct 20, 2023
Merged

[Improve][Flink] Remove useless stage type.#5650
hailin0 merged 1 commit into
apache:devfrom
CheneyYin:remove-flink-stage-type

Conversation

@CheneyYin
Copy link
Copy Markdown
Contributor

@CheneyYin CheneyYin commented Oct 18, 2023

Purpose of this pull request

PR(#5483) provide CatalogTable interface. SeaTunnel row type can be inferred from CatalogTable.getSeaTunnelRowType and bypass conversion from TypeInformation. So stageType related codes(#5419 ) are useless.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Reuse exist test cases.

Check list

@CheneyYin CheneyYin force-pushed the remove-flink-stage-type branch from 3ffe6c2 to 29ebdab Compare October 18, 2023 06:12
@CheneyYin CheneyYin marked this pull request as ready for review October 18, 2023 09:20
Copy link
Copy Markdown
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CheneyYin . LGTM

@hailin0 hailin0 merged commit 4341c7c into apache:dev Oct 20, 2023
@CheneyYin CheneyYin deleted the remove-flink-stage-type branch October 20, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants