Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Mark SeaTunnelPluginLifeCycle as deprecated #5625

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR mark SeaTunnelPluginLifeCycle as deprecated. Prepare to remove it.

Does this PR introduce any user-facing change?

No

How was this patch tested?

unnecessary

Check list

@Hisoka-X Hisoka-X added the api label Oct 13, 2023
@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Oct 13, 2023
@Hisoka-X
Copy link
Member Author

Hisoka-X commented Oct 13, 2023

We should remove it in 2.3.6, should not earlier than 2.3.6. We should leave time to developer which had customed their own plugin. But it depends on our progress on implement Factory SPI.

*/
@Deprecated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it will be deprecated in the future

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit eb6d4cf into apache:dev Oct 16, 2023
6 checks passed
@Hisoka-X Hisoka-X deleted the prepare-mark-deprecated branch October 17, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants