Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix][e2e][jdbc] Fix not remove docker image after test finish on jdbc suite #5586

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

CheneyYin
Copy link
Contributor

@CheneyYin CheneyYin commented Oct 1, 2023

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@CheneyYin CheneyYin marked this pull request as ready for review October 1, 2023 13:21
@CheneyYin CheneyYin force-pushed the fix-not-remove-image branch 3 times, most recently from b1e80e9 to 3354ffc Compare October 2, 2023 03:01
@CheneyYin
Copy link
Contributor Author

@Hisoka-X @liugddx PTAL

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X
Copy link
Member

Hisoka-X commented Oct 3, 2023

I think it will be invoked in TestCaseInvocationContextProvider::107
image

@CheneyYin
Copy link
Contributor Author

CheneyYin commented Oct 3, 2023

I think it will be invoked in TestCaseInvocationContextProvider::107 image

The AfterTestExecutionCallback just works on TestContainer, and AbstractJdbcIT didn't inherit TestContainer.

static class TestResourceProvidingInvocationContext implements TestTemplateInvocationContext {
private final TestContainer testContainer;
private final ContainerExtendedFactory containerExtendedFactory;
private final Integer containerAmount;
public TestResourceProvidingInvocationContext(

teardown

@Hisoka-X
Copy link
Member

Hisoka-X commented Oct 4, 2023

Thanks @CheneyYin , you are right!

@Hisoka-X Hisoka-X merged commit 70a3980 into apache:dev Oct 4, 2023
4 checks passed
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
@CheneyYin CheneyYin deleted the fix-not-remove-image branch January 11, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][e2e][jdbc] Fix not remove docker image after test finish on jdbc suite
3 participants