Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Remove catalogTable field in CatalogTableUtil #5521

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

Remove catalogTable field in CatalogTableUtil. As a util, it hold a CatalogTable instance is very strange.
In order to the other connector which invoke buildWithConfig work normally, add a method getSeaTunnelRowType in CatalogTable, the name same as CatalogTableUtil::getSeaTunnelRowType.

Does this PR introduce any user-facing change?

No

How was this patch tested?

exist test.

Check list

Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit 2887424 into apache:dev Sep 20, 2023
5 checks passed
@Hisoka-X Hisoka-X deleted the refactor-buildWithConfig branch September 21, 2023 02:42
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants