Skip to content

[Feature-#5258][Bin] Add .bat script for all shell script.#5445

Merged
EricJoy2048 merged 1 commit into
apache:devfrom
FlechazoW:add_windows_bat
Sep 11, 2023
Merged

[Feature-#5258][Bin] Add .bat script for all shell script.#5445
EricJoy2048 merged 1 commit into
apache:devfrom
FlechazoW:add_windows_bat

Conversation

@FlechazoW
Copy link
Copy Markdown
Contributor

Purpose of this pull request

Add .bat script for all shell script.

Check list

Comment thread config/seatunnel-env.cmd Outdated
Comment thread seatunnel-core/seatunnel-starter/src/main/bin/stop-seatunnel-cluster.cmd Outdated
@FlechazoW
Copy link
Copy Markdown
Contributor Author

@lvyanquan @EricJoy2048 PTAL

@lvyanquan
Copy link
Copy Markdown
Contributor

Overall, looks good to me.

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@EricJoy2048 EricJoy2048 merged commit ee4040b into apache:dev Sep 11, 2023
@FlechazoW FlechazoW deleted the add_windows_bat branch September 11, 2023 03:17
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants