Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][CheckStyle] Remove useless 'SuppressWarnings' annotation of checkstyle. #5260

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

FlechazoW
Copy link
Contributor

Remove useless 'SuppressWarnings' annotation of checkstyle.

Purpose of this pull request

Check list

@EricJoy2048
Copy link
Member

LGTM, Please wait CI.

@Hisoka-X
Copy link
Member

After we clean up these annotations, is there any benefit, what if someone adds corresponding annotations in the future?

@liugddx
Copy link
Member

liugddx commented Aug 18, 2023

After we clean up these annotations, is there any benefit, what if someone adds corresponding annotations in the future?

This annotation is provided by checkstyle, we are not using it now and checkstyle should not be added automatically.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, merging.

@Hisoka-X Hisoka-X merged commit 51c0d70 into apache:dev Aug 18, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants