Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][connector-clickhouse] fix get clickhouse local table name with closing bracket from distributed table engineFull #4710

Merged
merged 1 commit into from
May 16, 2023
Merged

[Hotfix][connector-clickhouse] fix get clickhouse local table name with closing bracket from distributed table engineFull #4710

merged 1 commit into from
May 16, 2023

Conversation

xifeng
Copy link
Contributor

@xifeng xifeng commented May 6, 2023

Purpose of this pull request

close #4482

Check list

[Hotfix][connector-clickhouse] fix get clickhouse local table name wi…
e131ea0 
…th closing bracket from distributed table engineFull
@xifeng xifeng marked this pull request as ready for review May 6, 2023 03:48
@xifeng
Copy link
Contributor Author

xifeng commented May 6, 2023 •
edited
Loading

@hailin0 @TyrantLucifer thanks

EricJoy2048
EricJoy2048 reviewed May 10, 2023
View reviewed changes
...n/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/client/ClickhouseProxy.java
@@ -86,7 +86,7 @@ public DistributedEngine getClickhouseDistributedTable(

String clusterName = infos.get(0);
String localDatabase = infos.get(1);
String localTable = infos.get(2).replace("\\)", "").trim();
String localTable = infos.get(2).replace(")", "").trim();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hisoka-X PTAL

@Hisoka-X Hisoka-X added this to the 2.3.2 milestone May 12, 2023
@EricJoy2048 EricJoy2048 merged commit e5e0cba into apache:dev May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@yabola yabola yabola approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 First-time contributor First-time contributor reviewed
Projects
None yet
Milestone
2.3.2
4 participants
@xifeng @yabola @EricJoy2048 @Hisoka-X