Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector][Elasticsearch] Support https protocol #3997

Merged
merged 1 commit into from
Feb 1, 2023
Merged

[Feature][Connector][Elasticsearch] Support https protocol #3997

merged 1 commit into from
Feb 1, 2023

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Jan 29, 2023

Purpose of this pull request

  • support https protocol
  • compatible with opensearch

Check list

@hailin0
Copy link
Member Author

hailin0 commented Jan 30, 2023

PTAL

CalvinKirs
CalvinKirs reviewed Jan 30, 2023
View reviewed changes
...rch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/util/DerUtils.java Outdated
Comment on lines 39 to 40
public final class DerUtils {
public static final int SEQUENCE_TAG = 0x30;
Copy link
Member

@CalvinKirs CalvinKirs Jan 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class looks to be from the airlift project, please confirm.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. please review

hailin0
hailin0 commented Jan 30, 2023
View reviewed changes
...c/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/client/EsRestClient.java
}

public BulkResponse bulk(String requestBody) {
Request request = new Request("POST", "_bulk");
Request request = new Request("POST", "/_bulk");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix https://bugs.chromium.org/p/gerrit/issues/detail?id=9761

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compatible with aws opensearch

@hailin0 hailin0 force-pushed the support-elasticsearch-https branch 2 times, most recently from 5ba48da to 23df106 Compare January 30, 2023 13:30
EricJoy2048
EricJoy2048 reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add release note to /release-note.md

@hailin0
[Feature][Connector][Elasticsearch] Support https protocol
3f19ec1 
* support https protocol
* compatible with opensearch
@hailin0
Copy link
Member Author

hailin0 commented Jan 31, 2023

Please add release note to /release-note.md

fixed @EricJoy2048

@TyrantLucifer TyrantLucifer merged commit 79b5cdd into apache:dev Feb 1, 2023
@kpretty
Copy link
Contributor

kpretty commented Feb 7, 2023

@hailin0 airlift depends on guava which seems to be incompatible with version 19.0 introduced by the parent project，exist NoSuchMethodError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJoy2048 EricJoy2048 EricJoy2048 left review comments

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

Assignees
No one assigned
Labels
approved improve reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hailin0 @kpretty @CalvinKirs @EricJoy2048 @TyrantLucifer