Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Connector-V2][Fake] Improve fake connector #3932

Merged
merged 8 commits into from
Jan 16, 2023

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

Support setting upbound and downbound for every data type

Check list

@TyrantLucifer TyrantLucifer marked this pull request as ready for review January 14, 2023 06:56
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +251 to +252
TINYINT_MIN.key() + " should >= " + TINYINT_MIN.defaultValue() +
" and <= " + TINYINT_MAX.defaultValue());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using String.format may be better.
There's a lot of code duplication like this, how about wrapping it as a method to return an error message?

@EricJoy2048 EricJoy2048 merged commit 31f1243 into apache:dev Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants