Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2][File] Support skip number when reading text csv files #3900

Merged
merged 6 commits into from
Jan 12, 2023
Merged

[Feature][Connector-V2][File] Support skip number when reading text csv files #3900

merged 6 commits into from
Jan 12, 2023

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

close #3276 #3192

Because I have no permit to push his branch, so I open another pull request.

Check list

TaoZex
TaoZex reviewed Jan 9, 2023
View reviewed changes
docs/en/connector-v2/source/FtpFile.md Outdated Show resolved Hide resolved
docs/en/connector-v2/source/LocalFile.md Outdated Show resolved Hide resolved
docs/en/connector-v2/source/OssFile.md Outdated Show resolved Hide resolved
docs/en/connector-v2/source/SftpFile.md Outdated Show resolved Hide resolved
@TyrantLucifer TyrantLucifer marked this pull request as ready for review January 9, 2023 09:23
@TyrantLucifer TyrantLucifer changed the title [Feature][Connector-V2][File] Support skip number when reading text json csv files [Feature][Connector-V2][File] Support skip number when reading text csv files Jan 9, 2023
TaoZex
TaoZex previously approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Hisoka-X
Hisoka-X previously approved these changes Jan 11, 2023
View reviewed changes
CalvinKirs
CalvinKirs reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add a test case?

@TyrantLucifer
Copy link
Member Author

LGTM, could you add a test case?

Yup, it's in progress.

@TyrantLucifer TyrantLucifer dismissed stale reviews from Hisoka-X and TaoZex via 8483b7d January 11, 2023 13:13
@Hisoka-X Hisoka-X merged commit 243b6a6 into apache:dev Jan 12, 2023
harveyyue pushed a commit to harveyyue/seatunnel that referenced this pull request Feb 7, 2023
@TyrantLucifer @harveyyue
[Feature][Connector-V2][File] Support skip number when reading text c…
72510c7 
…sv files (apache#3900)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaoZex TaoZex TaoZex approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TyrantLucifer @CalvinKirs @Hisoka-X @TaoZex @CallMeKingsley97