Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Connector-v2] Unset AutoCommit default to true #3451

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

ic4y
Copy link
Contributor

@ic4y ic4y commented Nov 16, 2022

Purpose of this pull request

Check list

@@ -129,9 +129,6 @@ public Connection getOrEstablishConnection()
"No suitable driver found for " + jdbcOptions.getUrl(), "08001");
}

//Auto commit is used by default
connection.setAutoCommit(true);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we set the autocommit parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set in url

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, some database implementations do not have the parameter autocommit, such as teradata. please track this https://teradata-docs.s3.amazonaws.com/doc/connectivity/jdbc/reference/current/frameset.html

Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ashulin ashulin merged commit 439f686 into apache:dev Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants