-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve] [Engine] Enables engine to configure all GC parameters #3307
Conversation
How about use |
Yes, not only heap memory size, we should can use it to set any jvm parameter. |
Thanks.I have modified the code and can set all gc parameters via JvmOption. Set a small gc heap size proves that JvmOption works: |
You should support config parameters in seatunnel-env.sh too. Thanks! |
seatunnel-env.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of this pull request
#3155
Enables engine to configure GC parameters Xms and Xmx
Start the engine directly and view the heap using jmap:
Configure Xms and Xmx for seatunnel-env.sh:
Start the engine again and view the heap using jmap
Check list
New License Guide