Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] [Engine] Enables engine to configure all GC parameters #3307

Merged
merged 5 commits into from
Nov 8, 2022

Conversation

TaoZex
Copy link
Contributor

@TaoZex TaoZex commented Nov 4, 2022

Purpose of this pull request

#3155
Enables engine to configure GC parameters Xms and Xmx

Start the engine directly and view the heap using jmap:
1

Configure Xms and Xmx for seatunnel-env.sh:
2

Start the engine again and view the heap using jmap
3

Check list

@TaoZex TaoZex closed this Nov 4, 2022
@TaoZex TaoZex reopened this Nov 4, 2022
@TaoZex TaoZex closed this Nov 4, 2022
@TaoZex TaoZex reopened this Nov 4, 2022
@TaoZex TaoZex closed this Nov 5, 2022
@TaoZex TaoZex reopened this Nov 5, 2022
@TyrantLucifer
Copy link
Member

How about use $@ to instead of it? Currently only heap memory size can be set, other jvm parameters are not supported, such as garbage collection. CC @Hisoka-X

@TaoZex TaoZex closed this Nov 5, 2022
@TaoZex TaoZex reopened this Nov 5, 2022
@Hisoka-X
Copy link
Member

Hisoka-X commented Nov 5, 2022

How about use $@ to instead of it? Currently only heap memory size can be set, other jvm parameters are not supported, such as garbage collection. CC @Hisoka-X

Yes, not only heap memory size, we should can use it to set any jvm parameter.

@TaoZex
Copy link
Contributor Author

TaoZex commented Nov 6, 2022

How about use $@ to instead of it? Currently only heap memory size can be set, other jvm parameters are not supported, such as garbage collection. CC @Hisoka-X

Yes, not only heap memory size, we should can use it to set any jvm parameter.

Thanks.I have modified the code and can set all gc parameters via JvmOption.

gc

Set a small gc heap size proves that JvmOption works:

gc1

@Hisoka-X
Copy link
Member

Hisoka-X commented Nov 7, 2022

You should support config parameters in seatunnel-env.sh too. Thanks!

@TaoZex
Copy link
Contributor Author

TaoZex commented Nov 7, 2022

You should support config parameters in seatunnel-env.sh too. Thanks!

Thanks for your advice,i have fixed it.

set JvmOption in seatunnel-env.sh config:

34fa3d1ba2759f3de19dd0fa6a3de6e

command input:

af53769795b6326df6ea0d120c5c5e0

Start the engine and view the heap using jmap:

295b84e7a2e1412259df9c2df9543d1

@TaoZex
Copy link
Contributor Author

TaoZex commented Nov 7, 2022

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TyrantLucifer TyrantLucifer merged commit 4fcb3ca into apache:dev Nov 8, 2022
@TaoZex TaoZex deleted the engine_gc branch November 8, 2022 07:40
@TaoZex TaoZex changed the title [Improve] [Engine] Enables engine to configure GC parameters Xms and Xmx [Improve] [Engine] Enables engine to configure all GC parameters Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants