Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Doc] Add doc about connector-v2 schema feature #3296

Merged
merged 7 commits into from
Nov 8, 2022

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Nov 3, 2022

close #3266

Purpose of this pull request

Check list

Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to the completion of the document

@liugddx liugddx marked this pull request as ready for review November 5, 2022 07:52
@liugddx
Copy link
Member Author

liugddx commented Nov 7, 2022

@Hisoka-X PTAL

EricJoy2048
EricJoy2048 previously approved these changes Nov 7, 2022
docs/en/concept/schema-feature.md Outdated Show resolved Hide resolved
}
```

step2:Add dependency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following is an introduction for developers. It is not necessary to put it here. This article is mainly to provide an introduction for users.

}
}
}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Add When we should use it or not?, because I can't know I can use schema on which source , I can't use schema on which source. (just only need metioned the connector config have schema key can use this feature)

@EricJoy2048 EricJoy2048 merged commit dce1cb7 into apache:dev Nov 8, 2022
EricJoy2048 added a commit that referenced this pull request Nov 8, 2022
@liugddx liugddx deleted the doc-schema branch November 10, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Doc] Add doc about connector-v2 schema feature
4 participants