Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2] influxdb sink connector #3174

Merged
merged 24 commits into from
Nov 8, 2022
Merged

[Feature][Connector-V2] influxdb sink connector #3174

merged 24 commits into from
Nov 8, 2022

Conversation

531651225
Copy link
Contributor

Purpose of this pull request

refer to #3018
add Influxdb sink connector

Check list

hailin0
hailin0 reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove old e2e testcase？

https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-influxdb-flink-e2e
https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-influxdb-spark-e2e

seatunnel-e2e/seatunnel-connector-v2-e2e/connector-influxdb-e2e/pom.xml Outdated Show resolved Hide resolved
...ector-influxdb-e2e/src/test/java/org/apache/seatunnel/e2e/connector/influxdb/InfluxdbIT.java Outdated Show resolved Hide resolved
@EricJoy2048 EricJoy2048 reopened this Oct 28, 2022
EricJoy2048
EricJoy2048 reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this connector to seatunnel-dist/pom.xml

@531651225
Copy link
Contributor Author

Please add this connector to seatunnel-dist/pom.xml
thinks，i have added in influxdb source connector， PTAL @EricJoy2048

图片

hailin0
hailin0 previously approved these changes Nov 7, 2022
View reviewed changes
TaoZex
TaoZex previously approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EricJoy2048
EricJoy2048 previously approved these changes Nov 7, 2022
View reviewed changes
@EricJoy2048 EricJoy2048 mentioned this pull request Nov 7, 2022
Open
3 tasks
@531651225 531651225 dismissed stale reviews from EricJoy2048, TaoZex, and hailin0 via 33c9ca7 November 7, 2022 11:19
@531651225 531651225 requested a review from ic4y November 8, 2022 05:34
ic4y
ic4y reviewed Nov 8, 2022
View reviewed changes
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/influxdb/sink/InfluxDBSinkWriter.java Outdated
}
}

public synchronized void write(Point record) throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to add synchronized, the writer is a single-threaded operation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to add synchronized, the writer is a single-threaded operation

thinks，i have fixed it in new commit. PTAL

...rc/main/java/org/apache/seatunnel/connectors/seatunnel/influxdb/sink/InfluxDBSinkWriter.java Outdated Show resolved Hide resolved
ic4y
ic4y approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@ic4y ic4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ic4y ic4y merged commit 630e884 into apache:dev Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ic4y ic4y ic4y approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@TaoZex TaoZex TaoZex left review comments

@hailin0 hailin0 hailin0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@531651225 @hailin0 @EricJoy2048 @TaoZex @ic4y