-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically #2641
Conversation
2b10412
to
6d30730
Compare
79abe86
to
0980661
Compare
This is a very helpful feature for us. @531651225 @legendtkl @TyrantLucifer @laglangyue @getChan @2013650523 @TaoZex @liugddx PTAL. |
tools/style/eclipse.importorder
Outdated
0=org.apache.seatunnel | ||
1=org.apache | ||
2=java | ||
3=javax | ||
4=org | ||
5=com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can scala be added?
And change the file name to seatunnel.importorder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestions. I will take a look and see whether we could add scala into it.
great |
@ashulin Sorry for the late update, I add extra configurations for scala formatting configurations and rename the previous https://github.com/apache/incubator-seatunnel/blob/dev/tools/checkstyle/suppressions.xml |
@ashulin PTAL |
Hi, @EricGao888 Is there any process here? If this is not convenient for you, I can continue to do this. |
Hello @FlechazoW , thanks for reaching out. Recently I've been quite busy with something else. I would appreciated it if you could help continue to complete this work. BTW, the configuration of |
Thanks for your advice, and I will perfect this as much as possible. |
Closed due to #2641 (comment) |
Purpose of this pull request
Checkstyle
andScala Style
withSpotless
to fix formatting and style errors automatically.java, .md, .scala
files.Check list
New License Guide