Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically #2641

Closed
wants to merge 5 commits into from

Conversation

EricGao888
Copy link
Member

@EricGao888 EricGao888 commented Sep 4, 2022

Purpose of this pull request

Check list

@EricJoy2048
Copy link
Member

This is a very helpful feature for us. @531651225 @legendtkl @TyrantLucifer @laglangyue @getChan @2013650523 @TaoZex @liugddx PTAL.

Comment on lines 18 to 23
0=org.apache.seatunnel
1=org.apache
2=java
3=javax
4=org
5=com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can scala be added?
And change the file name to seatunnel.importorder

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions. I will take a look and see whether we could add scala into it.

@hailin0
Copy link
Member

hailin0 commented Sep 29, 2022

great

@EricGao888
Copy link
Member Author

@ashulin Sorry for the late update, I add extra configurations for scala formatting configurations and rename the previous eclipse.importorder to seatunnel.importorder. BTW, I found there are lot of suppressions related to checkstyle, I suppose I need to remove them as well?

https://github.com/apache/incubator-seatunnel/blob/dev/tools/checkstyle/suppressions.xml
https://github.com/apache/incubator-seatunnel/blob/c29370a7b5bf6d70e4266b4b4b345e059a699148/seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/client/EsRestClient.java#L51

@EricJoy2048
Copy link
Member

@ashulin PTAL

@FlechazoW
Copy link
Contributor

Hi, @EricGao888 Is there any process here? If this is not convenient for you, I can continue to do this.

@EricGao888
Copy link
Member Author

EricGao888 commented Jan 12, 2023

Hi, @EricGao888 Is there any process here? If this is not convenient for you, I can continue to do this.

Hello @FlechazoW , thanks for reaching out. Recently I've been quite busy with something else. I would appreciated it if you could help continue to complete this work. BTW, the configuration of ratchetFrom in this PR may not function as expected. You may refer to diffplug/spotless#710 (comment) for a workaround. If possible, I suggest not using ratchetFrom but fixing the legacy formatting errors once for all.

@FlechazoW
Copy link
Contributor

Hi, @EricGao888 Is there any process here? If this is not convenient for you, I can continue to do this.

Hello @FlechazoW , thanks for reaching out. Recently I've been quite busy with something else. I would appreciated it if you could help continue to complete this work. BTW, the configuration of ratchetFrom in this PR may not function as expected. You may refer to diffplug/spotless#710 (comment) for a workaround. If possible, I suggest not using ratchetFrom and fix the legacy formatting errors once for all.

Thanks for your advice, and I will perfect this as much as possible.

@EricGao888
Copy link
Member Author

Closed due to #2641 (comment)

@EricGao888 EricGao888 closed this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI&CD First-time contributor First-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Style] Use Spotless to fix formatting and style errors automatically
7 participants