[Feature][seatunnel-datasource]: Add doris data source plugin #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome - so looking forward to this! |
| Doris: | ||
| businessMode: | ||
| - DATA_INTEGRATION | ||
| - DATA_REPLICA |
There was a problem hiding this comment.
As per the 2.3.8 documentation Doris does not support stream so DATA_REPLICA should not be added here
| @@ -83,6 +87,10 @@ public static String replaceJobConfigPlaceholders( | |||
| String escapeCharacter = matcher.group(1); | |||
| String placeholderName = matcher.group(2); | |||
|
|
|||
| if (SKIP_MATCH_KEY.contains(placeholderName.toUpperCase())) { | |||
There was a problem hiding this comment.
What is the scenario, why want to skip placeholder pattern maching?
There was a problem hiding this comment.
SEATUNEL has several placeholders for the sink in version 2.3.8, such as table_name. Details: https://seatunnel.apache.org/docs/2.3.8/concept/sink-options-placeholders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide