Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for failing SubscriptionFunctionalTest #85

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Fix for failing SubscriptionFunctionalTest #85

merged 1 commit into from
Mar 28, 2021

Conversation

mbien
Copy link
Member

@mbien mbien commented Mar 26, 2021

PlanetManagerLocalTest leaves a subscription behind which causes SubscriptionFunctionalTest to fail if it is run after it.

This attempts to fix it by removing the subscription in the teardown.

snoopdave
snoopdave approved these changes Mar 28, 2021
View reviewed changes
Copy link
Contributor

@snoopdave snoopdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbien mbien merged commit 0434cb3 into apache:master Mar 28, 2021
@mbien
Copy link
Member Author

mbien commented Mar 28, 2021

thanks dave!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoopdave snoopdave snoopdave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbien @snoopdave