Added Roller 6.1 db table upgrade logic + maven dependency upgrades #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated maven dependencies - guice 5 can be used again without the noaop tag on latest jdks - asm, spring, lucene, velocity etc updated webjars - bootstrap 3.4.1 is the last version before 4.x which comes with breaking changes checked JDK16 compatibility - required war plugin update in selenium pom
|
This LGTM except for the |
thanks for reviewing Dave! regarding the unrelated TagDataServlet warning: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table name change requires an upgrade script. Its very generic SQL but don't know on how many DBs this is going to work. I only tested it with HSQLDB.
updated maven dependencies
updated webjars
checked JDK16 compatibility