Code

Ipbanlist fixes#75

Code

Merged

mbien merged 7 commits intoapache:masterapache/roller:masterfrom nuzayats:ipbanlist_fixesnuzayats/roller:ipbanlist_fixesCopy head branch name to clipboardMay 22, 2021

Commits

Commits on Feb 11, 2021

• Add unit tests for the IPBanList class

  nuzayats

  committed
  7c8974f

  Copy full SHA for 7c8974f

• Use a synchronized set as it's shared across multiple threads and gets mutated

  nuzayats

  committed
  0fd0b39

  Copy full SHA for 0fd0b39

• Make a non-final log static field final, make an inner class static which doesn't have to be non-static

  nuzayats

  committed
  491c3b7

  Copy full SHA for 491c3b7

• Use ConcurrentHashMap.newKeySet() instead of a synchronized set for better performance

  nuzayats

  committed
  7620d3b

  Copy full SHA for 7620d3b

Commits on Feb 12, 2021

• Remove the forceLoad parameter which is always false from the loadBannedIpsIfNeeded() method as per review comment

  nuzayats

  committed
  a5417a5

  Copy full SHA for a5417a5

Commits on Feb 20, 2021

• Remove Mockito from pom.xml as it's not used at this point

  nuzayats

  committed
  15bf473

  Copy full SHA for 15bf473

Commits on May 22, 2021

• Remove AssertJ as per review comment

  nuzayats

  committed
  9dca2da

  Copy full SHA for 9dca2da