Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Renovations #66

Merged
merged 5 commits into from
Oct 11, 2020
Merged

Spring Renovations #66

merged 5 commits into from
Oct 11, 2020

Conversation

mbien
Copy link
Member

@mbien mbien commented Oct 2, 2020

This PR contains the spring changes of the wip branch.

  • spring upgrade to 5
  • implementation of a DelegatingPasswordEncoder for lazy upgrades to modern pw encodings

details in the commit messages.

Spring 4.2.4 added StrictHttpFirewall which throws RequestRejectedExceptions,
this servlet filter catches the exception, logs rejections and returns 404.
media file editor is used in an iframe. To allow this we have to set the policy to 'sameorigin'.
… as upgrade path from legacy encodings.

 - the default codec for db storage is now bcrypt (the other option is pbkdf2)
 - simple hashing functions like SHA and MD5 (which don't salt) are no longer supported
 - lazy upgrade is possible via the passwds.encryption.lazyUpgradeFrom=[SHA|MD5] property
 - the property won't be needed for future upgrades since the encoding is stored as prefix of the pw

TODO: only tested db setups, no LDAP
@mbien
Copy link
Member Author

mbien commented Oct 10, 2020

@snoopdave ready for review in case you missed this one.

@snoopdave
Copy link
Contributor

LGTM

@snoopdave snoopdave merged commit fe697f4 into apache:master Oct 11, 2020
@mbien
Copy link
Member Author

mbien commented Oct 12, 2020

@snoopdave thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants