Upgrade to struts 6.1.2 #124
Conversation
yes. see CI. Or try starting roller and open the management UI |
|
Checking the page the id has extra underscores. I will check if this is intentional.
|
|
i wouldn't recommend to skip so many major versions at once, this rarely works. The very next minor release already causes problems. last time I investigated (#118) i wrote down that it is likely the double evaluation change, but I can't remember why I thought that would be the case. |
|
Your are probably right here. Looking into this more, I did not realise the dependency soup with the bootstrap plugin. Plugin v5.00 uses bootstrap v5.2.0 where roller is using v3.4.1. |
|
Looking more into this there does not seem much of a lifeboat wrt the plugin. The general consensus is it is not possible upgrade this version of bootstrap (no surprise) . Seems a lot of changes on every major release, not the best use of resources. I did some testing and its not too difficult modify 4.0.1 to work with for example 6.1.2. A lot easier than upgrading bootstrap. See branch 4.0.2-struts-6.1.2. How to go forward with this is another question, maybe importing the code into roller?? |
|
you are saying that struts 2.5.30+ is not compatible with the bootstrap (plugin) version roller uses at the moment? I assumed it might have something to do with the double evaluation fix which is mentioned on the struts release notes. I hoped there might be a chance to update struts without bootstrap for now. |
|
Yes. The plugin needs some updates. If you compare branches you can see what's needed. Relatively simple in comparison to redoing bootstrap. |
From my testing of the UI this is all it needs to get to the latest version. Were there any failing tests?